do not call permute on empty tensor #3705
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D69635568 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Summary: X-link: facebookresearch/FBGEMM#787 short circuit if pooled embedding(s) is empty, otherwise we run into invalid CUDA kernel launch args this change is necessary to support zero batch size KeyedJaggedTensor embedding lookups conceptually, we cannot permute an empty tensor (i.e. `tensor.numel()==0`) so return the empty tensor Reviewed By: sryap Differential Revision: D69635568
sarckk
force-pushed
the
export-D69635568
branch
from
847db72 to
549ef94
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69635568 |
|
This pull request has been merged in 95099a6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
short circuit if pooled embedding(s) is empty, otherwise we run into invalid CUDA kernel launch args
this change is necessary to support zero batch size KeyedJaggedTensor embedding lookups
conceptually, we cannot permute an empty tensor (i.e.
tensor.numel()==0) so return the empty tensorReviewed By: sryap
Differential Revision: D69635568