Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change TORCH_LIBRARY to TORCH_LIBRARY_FRAGMENT #1645

Merged
merged 23 commits into from
Feb 12, 2025
Merged

Change TORCH_LIBRARY to TORCH_LIBRARY_FRAGMENT #1645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
7b73115
change TORCH_LIBRARY to TORCH_LIBRARY_FRAGMENT to prevent conflict be…
metascroy Jan 30, 2025
b7b047a
up
metascroy Feb 7, 2025
f5c39ba
up
metascroy Feb 7, 2025
835b77a
up
metascroy Feb 7, 2025
b26505a
up
metascroy Feb 7, 2025
20bf341
up
metascroy Feb 7, 2025
34b1dab
up
metascroy Feb 7, 2025
b7a2b36
up
metascroy Feb 7, 2025
19afc8e
up
metascroy Feb 7, 2025
d791cb9
up
metascroy Feb 7, 2025
4eb9e6d
up
metascroy Feb 10, 2025
6d7ead0
up
metascroy Feb 10, 2025
159e270
up
metascroy Feb 10, 2025
e7ec96b
up
metascroy Feb 10, 2025
9426c3b
up
metascroy Feb 10, 2025
16bd340
up
metascroy Feb 10, 2025
7d4e599
up
metascroy Feb 10, 2025
9ed7b50
up
metascroy Feb 10, 2025
7dff73d
up
metascroy Feb 10, 2025
3c0a37c
up
metascroy Feb 10, 2025
ffc9437
up
metascroy Feb 11, 2025
fd27bb2
up
metascroy Feb 11, 2025
85e1833
up
metascroy Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion torchao/experimental/ops/linear_8bit_act_xbit_weight/op_linear_8bit_act_xbit_weight_aten.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"_linear_8bit_act_" #weight_nbit "bit_weight", \
&linear_meta<weight_nbit, true>);

TORCH_LIBRARY(torchao, m) {
TORCH_LIBRARY_FRAGMENT(torchao, m) {
DEFINE_OP(1);
DEFINE_OP(2);
DEFINE_OP(3);
Expand Down
2 changes: 1 addition & 1 deletion torchao/experimental/ops/mps/linear_fp_act_xbit_weight_aten.mm
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manuelcandales how do I test the change? Is there a script I should run?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

cd ao/torchao/experimental/ops/mps
bash build.sh
python test/test_lowbit.py

Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ Tensor pack_weights_cpu_kernel(const Tensor& W) {
return B;
}

TORCH_LIBRARY(torchao, m) {
TORCH_LIBRARY_FRAGMENT(torchao, m) {
m.def("_pack_weight_1bit(Tensor W) -> Tensor");
m.def("_pack_weight_2bit(Tensor W) -> Tensor");
m.def("_pack_weight_3bit(Tensor W) -> Tensor");
Expand Down
Loading