-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reduce computations in backprop of lfilter
#3831
feat: reduce computations in backprop of lfilter
#3831
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3831
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 3 Cancelled Jobs, 6 Unrelated FailuresAs of commit 28575a7 with merge base 97ed7b3 (): NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good. Do you want to update the docstring to mention the new algorithm / paper?
Oh, sure, I totally forgot. Will update the docstring later this week. |
The code passes related unit tests on my computer. |
This PR update the backpropagation computation of
DifferentiableIIR
.The update is based on my recent work (https://arxiv.org/abs/2406.05128), which uses just one
DifferentiableIIR::apply
instead of two to compute the gradients for both input anda_coeffs
. The algorithm has been tested in torchlpc.Below is the benchmark to version 2.4.1
lfilter
.The backward computation runs slightly faster especially when using just one thread.
v2.4.1
This version