Commits on Nov 18, 2024

1. Fix type-safety of torch.nn.Module instances …

   Summary:
   X-link: ctrl-labs/src2#38809
   
   As laid out in pytorch/pytorch#81462 (comment) the change in pytorch/pytorch#104321 was not necessary and largely destroys the type-safety of `torch.nn.Module` instances.
   
   As far as I can see, the underlying issue of pytorch/pytorch#81462 in `torch.nn.parallel.DistributedDataParallel` has been fixed in the meantime by actually typing `register_comm_hook` correctly.
   
   The proper solution to issues like pytorch/pytorch#81462 is to give the underlying field/method a proper type annotation, then there should be no need to go for a "type system disabling `__getattr__`".
   
   (I'll probably be offline for a while, not able to react here...)
   
   cc H-Huang awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov avikchaudhuri gmagogsfm zhxchen17 tugsbayasgalan angelayi suo ydwu4 XilunWu rec mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse tianyu-l kiukchung lucasllc
   
   X-link: pytorch/pytorch#115074
   
   Differential Revision: D52890934
   
   Pulled By: ezyang

   

   bluenote10 authored and facebook-github-bot committed Nov 18, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 03867a9
   • Browse repository at this point

   Copy the full SHA

   03867a9 View commit details

   Browse the repository at this point in the history