Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Filter node #1427

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add Filter node #1427

wants to merge 4 commits into from

Conversation

ramanishsingh
Copy link
Contributor

No description provided.

@ramanishsingh
initial_commit
3789545
@ramanishsingh
add tests
6112828
@ramanishsingh
update test_filter
7202377 
update filter

state management

update filter

add filter

delete unnecessary files
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 22, 2025
@ramanishsingh
run precommit
d6e6356 
add coment

clean up
@ramanishsingh ramanishsingh marked this pull request as draft January 22, 2025 23:45
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1427

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 13 Unrelated Failures

As of commit d6e6356 with merge base 4ec4548 (image):

NEW FAILURES - The following jobs have failed:

  • Lint / mypy (gh)
    torchdata/nodes/filter.py:150:20: error: Cannot use a covariant type variable
  • Lint / style (gh)
    Process completed with exit code 1.

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramanishsingh @facebook-github-bot