Skip to content

Commit

Permalink
Deactivate version symbol check (#380)
Browse files Browse the repository at this point in the history
  • Loading branch information
NicolasHug authored Nov 18, 2024
1 parent 2755c89 commit 5106161
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions packaging/post_build_script.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,12 @@ assert_not_in_wheel $wheel_path "^benchmarks"
assert_not_in_wheel $wheel_path "^packaging"

if [[ "$unamestr" == 'Linux' ]]; then
# See invoked python script below for details about this check.
extracted_wheel_dir=$(mktemp -d)
unzip -q $wheel_path -d $extracted_wheel_dir
symbols_matches=$(find $extracted_wheel_dir | grep ".so$" | xargs objdump --syms | grep GLIBCXX_3.4.)
python packaging/check_glibcxx.py "$symbols_matches"
# TODO: Put this back with higher upper bound of version symbol.
# # See invoked python script below for details about this check.
# extracted_wheel_dir=$(mktemp -d)
# unzip -q $wheel_path -d $extracted_wheel_dir
# symbols_matches=$(find $extracted_wheel_dir | grep ".so$" | xargs objdump --syms | grep GLIBCXX_3.4.)
# python packaging/check_glibcxx.py "$symbols_matches"

echo "ls dist"
ls dist
Expand Down

0 comments on commit 5106161

Please sign in to comment.