Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[torchcodec] refactor test utils into its own library #25

Closed
wants to merge 2 commits into from
Closed

[torchcodec] refactor test utils into its own library #25

wants to merge 2 commits into from

Conversation

scotts
Copy link
Contributor

@scotts scotts commented Jun 13, 2024

Summary:
Refactors utility functions that were defined directly in test source files into a library that can be shared among tests. This diff:

  1. Creates a Python test utility library that can be imported by Python tests.
  2. Moves the test resources to the test top-level.
  3. Defines a C++ target for those resources.

This is in preparation for adding new tests that will need this library.

Differential Revision: D58530481

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jun 13, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58530481

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58530481

6 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58530481

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58530481

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58530481

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58530481

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58530481

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58530481

@NicolasHug NicolasHug mentioned this pull request Jun 14, 2024
Closed
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58530481

6 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58530481

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58530481

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58530481

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58530481

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58530481

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58530481

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58530481

3 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58530481

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58530481

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58530481

@scotts @facebook-github-bot
[torchcodec] refactor test utils into its own library (#25)
214a063 
Summary:
Pull Request resolved: #25

Refactors utility functions that were defined directly in test source files into a library that can be shared among tests. This diff:

1. Creates a Python test utility library that can be imported by Python tests.
2. Moves the test resources to the test top-level.
3. Defines a C++ target for those resources.

This is in preparation for adding new tests that will need this library.

Reviewed By: NicolasHug

Differential Revision: D58530481
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58530481

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6f2bd31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scotts @facebook-github-bot