Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simpler experiment names #411

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Simpler experiment names #411

merged 2 commits into from
Nov 25, 2024

Conversation

scotts
Copy link
Contributor

@scotts scotts commented Nov 24, 2024

  1. Simplifies experiment names, naming them more after what they do rather than how they do it.
  2. Renames the actual methods to match.
  3. Unifies where those names come from. (Except for the concurrency experiment, which is already a special case.)
  4. Moves the stamp to the bottom left. It's overlapping with text in the upper left.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 24, 2024
@scotts scotts marked this pull request as ready for review November 24, 2024 04:51
ahmadsharif1
ahmadsharif1 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@ahmadsharif1 ahmadsharif1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO "decode" feels a bit more explicit/accurate compared to "sample"

@scotts
Copy link
Contributor Author

scotts commented Nov 25, 2024

@ahmadsharif1, sure let's go with that.

@scotts scotts merged commit f9dd9b5 into pytorch:main Nov 25, 2024
37 of 47 checks passed
@scotts scotts deleted the readme_chart_exp_names branch November 25, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmadsharif1 ahmadsharif1 ahmadsharif1 approved these changes

@NicolasHug NicolasHug Awaiting requested review from NicolasHug

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scotts @ahmadsharif1 @facebook-github-bot