[torchcodec] simple video decoder constructor now accepts path objects #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D59309882
Summary: Addresses TODO in code. `SimpleVideoDecoder` now accepts a `pathlib.Path` object directly. We still have to call a string constructor on it, as the underlying core function needs to take a string, but this is a usability improvement. Differential Revision: D59325727
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59325727 |
|
This pull request has been merged in 8f1c911. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Addresses TODO in code.
SimpleVideoDecodernow accepts apathlib.Pathobject directly. We still have to call a string constructor on it, as the underlying core function needs to take a string, but this is a usability improvement.Differential Revision: D59325727