Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inference example and polish CMAKE paths and README #2511

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix inference example and polish CMAKE paths and README #2511

wants to merge 1 commit into from

Conversation

PaulZhang12
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 23, 2024
agunapal
agunapal reviewed Oct 23, 2024
View reviewed changes
Copy link

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is gRPC needed for TorchRec or this for the server being shown in the example?

We do have a pytest for dlrm in TorchServe. Might be also worth showing a script example of torchrec inference working? I am working on a standalone script. Will share once ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agunapal agunapal agunapal left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PaulZhang12 @agunapal @facebook-github-bot