Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect duplicate save/load recipes to the main save/load tutorial #3136

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

Saiteja64
Copy link
Contributor

@Saiteja64 Saiteja64 commented Oct 31, 2024

Fixes #ISSUE_NUMBER

Description

  1. Currently, if there are any rst files not directly in a src directory they are not picked up by the conf.py script. Update the script to also pick up recursive directories.

  2. Redirect duplicate save/load recipes to the main save/load tutorial

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

Copy link

pytorch-bot bot commented Oct 31, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3136

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 08fb23d with merge base 54273de (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Saiteja64 Saiteja64 changed the title Update conf.py to copy rst files from src recursive directories as well Redirect duplicate save/load recipes to the main save/load tutorial Oct 31, 2024
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The link check failure for https://pytorch.org/tutorials/recipes/amp_recipe.html seems to be unrelated to this PR

@Saiteja64 Saiteja64 merged commit a408ba5 into main Nov 1, 2024
19 of 20 checks passed
@svekars svekars deleted the copy_rst_files_from_recursive_src_dirs branch November 4, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants