Added serializing into bytes object
#71
Conversation
|
@KOLANICH This requires a re-base. |
|
Thank you, but we are still waiting on the PR (and release?) in libdatrie for this to be mergeable? What commit is the submodule pointing at now? |
|
I have sent there a PR, but when a PR is sent, GH puts the commits into the repo (proof), so submodules should work even if that PR is not merged yet. |
|
if the PR gets closed without being merged or you change the PR (either by just adding more commits or by force-pushing new commits) what will make sure the commit we are relying on here does not get "garbage collected" by github? |
|
If it is your concern, you can fork that repo and fetch the branch from mine. I don't want to tie this project to my fork of that repo because I plan to delete it as soon as everything I need merged. |
KOLANICH
force-pushed
the
fileless
branch
6 times, most recently
from
a15d98c to
3a90c30
Compare
|
The upstream PR still appears to not be merged? |
|
@tacaswell, it's merged into the upstream. |
KOLANICH
force-pushed
the
fileless
branch
3 times, most recently
from
e7feac4 to
c6e359a
Compare
2 similar comments
This PR requires tlwg/libdatrie#12 to be merged first (or maybe create an own fork of that lib, because that fork is inactive).