Adding back support for arm64 macOS wheels. #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By running the build task on an arm64 runner we get wheels that include the dependency libraries (libfreetype, and libpng).
devbanu
commented
Mar 4, 2024
|
I've seen this failure before: But I don't remember how I fixed it. Any ideas? |
|
This makes sense to me. I'm on paternity leave though so I can't promise I'll be able to make a new release tonight or tomorrow, but I'll try my best. |
|
Oh and thanks for getting this done. |
|
Thanks! Enjoy the paternity leave! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Following our discussion in #92, I finally found time to look into and fix it.
Previously x86_64 macOS runners where used in trying to build both x86_64 and arm64 wheels. This produced working x86_64 wheels, but incomplete arm64 wheels (dependent libraries libreetype and libpng where not copied over since they were available only in the x86_64 version).
The problem is solved by building the arm64 wheels on an arm64 macOS runner.