Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Listener and ListenerContainer logger names #68

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Nov 15, 2024

This PR changes the logger names for Listener and ListenerContainer to be categorical, so prefixing them with posttroll.listener. so that the log messages are coming from posttroll.listener.Listener and posttroll.listener.ListenerContainer respectively.

Closes #67

@pnuu pnuu requested a review from gerritholl November 15, 2024 10:54
@pnuu pnuu self-assigned this Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.63%. Comparing base (90ebc98) to head (efa3e36).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
posttroll/address_receiver.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   89.59%   89.63%   +0.03%     
==========================================
  Files          25       25              
  Lines        2278     2286       +8     
==========================================
+ Hits         2041     2049       +8     
  Misses        237      237              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gerritholl gerritholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for addressing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for review
Development

Successfully merging this pull request may close these issues.

posttroll.listener should use hierarchical logger custom
3 participants