Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added External Colormap #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tecnavia-dev
Copy link

Added External Colormap, readed from a configuration file.

@codecov
Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #19 into master will increase coverage by 0.02%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   38.67%   38.69%   +0.02%     
==========================================
  Files           7        7              
  Lines        3160     3163       +3     
==========================================
+ Hits         1222     1224       +2     
- Misses       1938     1939       +1
Impacted Files Coverage Δ
pyninjotiff/ninjotiff.py 59.19% <75%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c6295f...5280667. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could add a test for this it would be great!

cmap = _default_colormap(reverse)
cmap = kwargs.get("color_map", None)
if cmap is not None:
#cmap = [x * 256 for x in cmap] * 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line isn't needed, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants