Deprecate PPP_CONFIG_DIR for specifying config path

[djhoese]

This is a continuation of #169 to more fully deprecate PPP_CONFIG_DIR.

This may need updating to have it raise an exception completely. Further discussion is needed. Due to the previous deprecation warning, this PR should not be released until 1.9 is ready.

CC @pnuu @mraspaud @adybbroe

• Closes #xxxx
• Tests added
• Tests passed
• Passes flake8 pyorbital
• Fully documented

[djhoese]

Oh I also made pytest more strict and removed usage of datetime utcnow.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.48%. Comparing base (7eb57a5) to head (805d2cf).
Report is 39 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   88.45%   88.48%   +0.02%     
==========================================
  Files          16       16              
  Lines        2391     2397       +6     
==========================================
+ Hits         2115     2121       +6     
  Misses        276      276              

Flag	Coverage Δ
unittests	88.48% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pnuu]

I don't see utcnow in the diff, forgot to commit/push that bit?

[coveralls]

coverage: 88.442% (+0.03%) from 88.414%
when pulling 805d2cf on djhoese:dep-env-var
into 1e651fb on pytroll:main.

[adybbroe]

Looks good, thanks.

[adybbroe]

I don't see utcnow in the diff, forgot to commit/push that bit?

What do you mean? I am not following, sorry

[pnuu]

I don't see utcnow in the diff, forgot to commit/push that bit?

What do you mean? I am not following, sorry

Above @djhoese said

Oh I also made pytest more strict and removed usage of datetime utcnow.

I don't see anything related to utcnow in the PR diff, so I was wondering whether something is still missing.

[djhoese]

Ah yep. I'm just waking up and won't be in front of the computer for a while (kid's doctor appointment). I'll see if I can push it while getting kids ready for the day.

[mraspaud]

LGTM! I suppose v1.9 is the next release then, right?

[mraspaud]

oh, looks like tests are failing...

[djhoese]

Since this requires a 1.9 release I'll let others (@adybbroe ?) answer whether or not this should be merged and released in 1.9 next or if there should be a 1.8.x release first.

[pnuu]

LGTM.

I merged main and resolved the conflicts, should be ready to merge now.

[pnuu]

Version 1.9.0 is now released, so I'll merge this.

[djhoese]

This was meant to be released as part of 1.9.0 based on the warning messages.

[pnuu]

Damn, I read this the wrong way around 🙈

Since this requires a 1.9 release I'll let others (@adybbroe ?) answer whether or not this should be merged and released in 1.9 next or if there should be a 1.8.x release first.

[djhoese]

Maybe a 1.9.1 release then?

[pnuu]

Will do, now that the release deployment was fix in #172 😁