Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to cibuildwheel for wheel building #542

Merged
merged 7 commits into from
Sep 25, 2023

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Sep 21, 2023

Join the modern world and use cibuildwheel to build wheels.

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff
  • Fully documented

@djhoese djhoese added enhancement dependencies Pull requests that update a dependency file labels Sep 21, 2023
@djhoese djhoese self-assigned this Sep 21, 2023
@djhoese
Copy link
Member Author

djhoese commented Sep 21, 2023

@mraspaud Ah we need Python 3.12 wheels for pykdtree. I guess I'll do the equivalent of this PR there.

@mraspaud
Copy link
Member

thanks!

@djhoese
Copy link
Member Author

djhoese commented Sep 22, 2023

The CI failures will be fixed when PROJ 9.3.1 is released:

OSGeo/PROJ#3873

9.3.0 still triggers the inequality.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #542 (36f00c7) into main (3e7de5d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #542   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files          82       82           
  Lines       13077    13077           
=======================================
  Hits        12326    12326           
  Misses        751      751           
Flag Coverage Δ
unittests 94.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@coveralls
Copy link

Coverage Status

coverage: 93.833%. remained the same when pulling 36f00c7 on djhoese:ci-cibuildwheel into 3e7de5d on pytroll:main.

@djhoese
Copy link
Member Author

djhoese commented Sep 24, 2023

FYI @mraspaud, feel free to review and merge this. This does NOT enable Python 3.12 because shapely does not have wheels for it you (I'm working on that in shapely/shapely#1893) and I also excluded the specific version of PROJ that causes our one .cfg -> YAML area definition test to fail until PROJ 9.3.1 is released.

Once the shapely PR is merged and a wheel released we can do a release. I'd love for all of pytroll's packages to have Python 3.12 wheels available on PyPI when 3.12's first stable release comes out.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mraspaud mraspaud merged commit 48f10d3 into pytroll:main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants