Add missing meta keyword arguments on all dask map_blocks calls #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhoese
force-pushed
the
bugfix-dask-meta
branch
from
d9b76f5 to
d8b5e82
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
=======================================
Coverage 93.99% 93.99%
=======================================
Files 92 92
Lines 13777 13777
=======================================
Hits 12950 12950
Misses 827 827
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the
meta=keyword argument toda.map_blocksdask will call the mapped function with fake/representative arguments to try to determine what the returned array and dtype are. This PR adds this kwarg to avoid this unnecessary execution of the function.This very likely won't have any effect on performance, but it helps with debugging and is an unnecessary call if you forget it.
git diff origin/main **/*py | flake8 --diff