Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor area boundary sides retrieval with _geographic_sides and _projection_sides methods #566

Merged
merged 9 commits into from
Dec 8, 2023

Fix type annotations in geometry.py

aee90a1
Select commit
Loading
Failed to load commit list.
Merged

Refactor area boundary sides retrieval with _geographic_sides and _projection_sides methods #566

Fix type annotations in geometry.py
aee90a1
Select commit
Loading
Failed to load commit list.
codefactor.io / CodeFactor failed Dec 8, 2023 in 1s

4 issues found.

Annotations

Check notice on line 355 in pyresample/geometry.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

pyresample/geometry.py#L355 

unresolved comment '# FIXME: ~(~np.isfinite(dim1_side) | ~np.isfinite(dim1_side))' (C100)

Check notice on line 364 in pyresample/geometry.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

pyresample/geometry.py#L364 

unresolved comment '# FIXME: This currently replicate values if heigh/width < row_num/col_num !' (C100)

Check notice on line 641 in pyresample/geometry.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

pyresample/geometry.py#L641 

unresolved comment '# FIXME: Add logic for out-of-earth disk projections' (C100)

Check notice on line 2783 in pyresample/geometry.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

pyresample/geometry.py#L2783 

unresolved comment '# FIXME: Add logic for out-of-earth-disk' (C100)
View more details on codefactor.io