-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make documentation generation faster #2875
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2875 +/- ##
=======================================
Coverage 96.06% 96.06%
=======================================
Files 370 370
Lines 54320 54320
=======================================
Hits 52185 52185
Misses 2135 2135
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 10655171223Details
💛 - Coveralls |
Ok, pyresample 1.30.0 is now out, do you think this is ready? |
Not really. Once I get RTD builds working then we have to decide if we like the eay it looks. Then I need to update the documentation to explain how to run the script before running the normal sphinx build commands. |
@mraspaud @BENR0 What do you think (scroll down and expand the "Map" sections): https://satpy--2875.org.readthedocs.build/en/2875/resample.html#area-definitions-included-in-satpy |
@mraspaud I kind of wonder if I should make it so the area list is only generated from the |
That seems reasonable. We just need to make sure we generate it locally whenever we change that code... |
@mraspaud so I did the bare minimum and (if it works) told RTD to only generate the file on "latest" or "stable" documentation builds. Otherwise it just creates an empty version of the file. I could maybe create the file and commit it to the repository with some basic placeholder text like "Area definition list has not been generated. Run 'python generate_area_def_list.py' to generate it. The list is automatically generated when creating the 'latest' and 'stable' builds of the website on readthedocs.io". But I'd also need to then |
Yepp like what you did with the template. Although in the link you posted there are now area defs listed for me. |
Yes, sorry @BENR0. I realized that right after I made the commit. I'll merge this to make sure my technique works and then any requested changes can go in a future PR. I'll comment when the build finishes so you can review the area overviews. |
@BENR0 Here you go: https://satpy.readthedocs.io/en/latest/resample.html#area-definitions-included-in-satpy Looks like based on my time log messages that it takes ~4 minutes to generate these. |
Thanks for fixing this! |
Yepp nice, thanks for the fix. |
Closes #2864
Requires pytroll/pyresample#615
AUTHORS.md
if not there already