Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of EUMETSAT IASI-NG reader #2879

Open
wants to merge 56 commits into
base: main
Choose a base branch
from

Minor refactoring using try/except.

75cf6c9
Select commit
Loading
Failed to load commit list.
Open

Initial implementation of EUMETSAT IASI-NG reader #2879

Minor refactoring using try/except.
75cf6c9
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Feb 5, 2025 in 51s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Code Health of new files: 9.43

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Code Duplication test_iasi_ng_l2_nc.py
  • Excess Number of Function Arguments test_iasi_ng_l2_nc.py: add_dataset_variable

Annotations

Check warning on line 377 in satpy/tests/reader_tests/test_iasi_ng_l2_nc.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Code Duplication 

The module contains 5 functions with similar structure: TestIASINGL2NCReader.test_apply_fill_value,TestIASINGL2NCReader.test_apply_fill_value_range,TestIASINGL2NCReader.test_ignore_pattern_variable,TestIASINGL2NCReader.test_ignore_scalar_variable and 1 more functions. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.

Check warning on line 162 in satpy/tests/reader_tests/test_iasi_ng_l2_nc.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments 

add_dataset_variable has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
View more details on CodeScene Delta Analysis