A new reader for the netcdf sent to Icare by Meteo-France. #2911
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Code Health of new files: 9.00
- Declining Code Health: 9 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Code Duplication test_geos_netcdficare.py
- Large Method test_geos_netcdficare.py: TestGeosNetcdfIcareReader.buildNetcdf
- Complex Method geos_netcdficare.py: NETCDF_ICARE.get_dataset
- Complex Method test_geos_netcdficare.py: TestGeosNetcdfIcareReader.checkingSceneParameter
- Excess Number of Function Arguments test_geos_netcdficare.py: TestGeosNetcdfIcareReader.buildNetcdf
- Bumpy Road Ahead geos_netcdficare.py: NETCDF_ICARE.get_dataset
- Bumpy Road Ahead test_geos_netcdficare.py: TestGeosNetcdfIcareReader.checkingSceneParameter
- Excess Number of Function Arguments test_geos_netcdficare.py: TestGeosNetcdfIcareReader.visibleChannelsCreation
- Excess Number of Function Arguments test_geos_netcdficare.py: TestGeosNetcdfIcareReader.infrarougeChannelsCreation
Annotations
Check warning on line 642 in satpy/readers/geos_netcdficare.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
NETCDF_ICARE.get_dataset has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 642 in satpy/readers/geos_netcdficare.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
NETCDF_ICARE.get_dataset has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 221 in satpy/tests/reader_tests/test_geos_netcdficare.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Code Duplication
The module contains 6 functions with similar structure: TestGeosNetcdfIcareReader.infrarougeChannelsCreation,TestGeosNetcdfIcareReader.initGoesr,TestGeosNetcdfIcareReader.initHima,TestGeosNetcdfIcareReader.initMsg and 2 more functions. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
Check warning on line 168 in satpy/tests/reader_tests/test_geos_netcdficare.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
TestGeosNetcdfIcareReader.checkingSceneParameter has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 531 in satpy/tests/reader_tests/test_geos_netcdficare.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Large Method
TestGeosNetcdfIcareReader.buildNetcdf has 73 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check warning on line 168 in satpy/tests/reader_tests/test_geos_netcdficare.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
TestGeosNetcdfIcareReader.checkingSceneParameter has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 531 in satpy/tests/reader_tests/test_geos_netcdficare.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Excess Number of Function Arguments
TestGeosNetcdfIcareReader.buildNetcdf has 15 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check warning on line 557 in satpy/tests/reader_tests/test_geos_netcdficare.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Excess Number of Function Arguments
TestGeosNetcdfIcareReader.visibleChannelsCreation has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check warning on line 586 in satpy/tests/reader_tests/test_geos_netcdficare.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Excess Number of Function Arguments
TestGeosNetcdfIcareReader.infrarougeChannelsCreation has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.