Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scale factor and offset [viirs_l1b] #3016

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

zxdawn
Copy link
Member

@zxdawn zxdawn commented Dec 13, 2024

The scale factor and offset should be updated for BT data. The easiest way seems to be updating these parameters using the factor output.

@zxdawn zxdawn requested a review from djhoese as a code owner December 13, 2024 19:57
@zxdawn zxdawn changed the title Update scale factor and offset [viird_l1b] Update scale factor and offset [viirs_l1b] Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (5984c29) to head (9f9dbda).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3016   +/-   ##
=======================================
  Coverage   96.10%   96.10%           
=======================================
  Files         377      377           
  Lines       55163    55182   +19     
=======================================
+ Hits        53012    53031   +19     
  Misses       2151     2151           
Flag Coverage Δ
behaviourtests 3.94% <0.00%> (-0.01%) ⬇️
unittests 96.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

satpy/readers/viirs_l1b.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Dec 13, 2024

Pull Request Test Coverage Report for Build 12332194278

Details

  • 19 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 96.208%

Totals Coverage Status
Change from base Build 12299617024: 0.002%
Covered Lines: 53275
Relevant Lines: 55375

💛 - Coveralls

@zxdawn zxdawn requested a review from mraspaud as a code owner December 14, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants