-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GOES-19 RGB2XYZ matrix for true_color_reproduction
#3054
Conversation
NOTE: I haven't had a chance to try this on actual G-19 data, but as the values are close to those for the other GOES satellites I expect it to work fine. I suggest not merging until we get feedback either from the user in #3053 or from someone else who gives this a go with the real data. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3054 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 383 383
Lines 55673 55685 +12
=======================================
+ Hits 53511 53523 +12
Misses 2162 2162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 13229546272Details
💛 - Coveralls |
I have now tested this with GOES-19 and it correctly generates the |
Could you post an example image? |
(post deleted due to error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also prefer the standard true_color
one, but as I don't use true_color_reproduction
I won't stand in the way of anybody who wants to use it like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Adds theRGB-to-XYZ conversion matrix required by the
true_color_reproduction
composite for the GOES-19 spacecraft. This satellite was previously missing. Note: Matrix is not optimal as GOES/ABI misses a green band, and hence here we use a hybrid matrix that assumes the value of the green band computes for GOES/ABI.