Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GOES-19 RGB2XYZ matrix for true_color_reproduction #3054

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

simonrp84
Copy link
Member

@simonrp84 simonrp84 commented Feb 9, 2025

Adds theRGB-to-XYZ conversion matrix required by the true_color_reproduction composite for the GOES-19 spacecraft. This satellite was previously missing. Note: Matrix is not optimal as GOES/ABI misses a green band, and hence here we use a hybrid matrix that assumes the value of the green band computes for GOES/ABI.

@simonrp84
Copy link
Member Author

NOTE: I haven't had a chance to try this on actual G-19 data, but as the values are close to those for the other GOES satellites I expect it to work fine. I suggest not merging until we get feedback either from the user in #3053 or from someone else who gives this a go with the real data.

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (f388e6f) to head (f4ae31b).
Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3054   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files         383      383           
  Lines       55673    55685   +12     
=======================================
+ Hits        53511    53523   +12     
  Misses       2162     2162           
Flag Coverage Δ
behaviourtests 3.88% <ø> (-0.01%) ⬇️
unittests 96.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13229546272

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.222%

Totals Coverage Status
Change from base Build 13202979421: 0.0%
Covered Lines: 53770
Relevant Lines: 55881

💛 - Coveralls

@pnuu pnuu added enhancement code enhancements, features, improvements component:enhancements labels Feb 10, 2025
@simonrp84
Copy link
Member Author

I have now tested this with GOES-19 and it correctly generates the true_color_reproduction composite as expected. Therefore, this PR is ready to merge as (I think) the one test failure is unrelated and is happening on all the other PRs too...

@gerritholl
Copy link
Member

gerritholl commented Feb 11, 2025

Could you post an example image?

@simonrp84
Copy link
Member Author

simonrp84 commented Feb 11, 2025

(post deleted due to error)

Copy link
Member

@gerritholl gerritholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also prefer the standard true_color one, but as I don't use true_color_reproduction I won't stand in the way of anybody who wants to use it like this.

@simonrp84
Copy link
Member Author

I slightly updated the matrix due to an error in my code. New one committed now!

It made very little difference to the images compared to those shown in my (now deleted) previous comment. Top, true_color. Bottom, true_color_reproduction.
tc

tcr

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mraspaud mraspaud merged commit b6b4ef1 into pytroll:main Feb 12, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:enhancements enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No conversion matrix found for platform GOES-19
5 participants