Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'oci_l2_bgc' to allow .nc4 and .nc filename extensions #3055

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 11, 2025

@kathys let me know that the files this reader is meant to read now come with a .nc extension. This PR fixes the reader to allow the older .nc4 extension and the newer .nc extension.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (da46066) to head (f7d5dba).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3055   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files         383      383           
  Lines       55685    55685           
=======================================
  Hits        53523    53523           
  Misses       2162     2162           
Flag Coverage Δ
behaviourtests 3.88% <ø> (ø)
unittests 96.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit c776b26 into pytroll:main Feb 11, 2025
17 of 18 checks passed
@djhoese djhoese deleted the bugfix-oci-l2-bgc-filename branch February 11, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants