-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/pyproject-support #625
Conversation
WalkthroughThe changes in this pull request modify the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
safety/scan/ecosystems/python/dependencies.py (1)
288-294
: Consider adding test coverage for pyproject.toml parsingThe changes look good, but we should ensure proper test coverage for the new file type support.
Would you like me to help create test cases for pyproject.toml parsing? This should include:
- Basic dependency parsing from pyproject.toml
- Error handling for malformed pyproject.toml files
- Integration tests with the safety CLI
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- safety/scan/ecosystems/python/dependencies.py (1 hunks)
🔇 Additional comments (1)
safety/scan/ecosystems/python/dependencies.py (1)
294-294
: LGTM: Added newline at end of fileAdding a newline at the end of the file follows the standard convention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds support for pyproject.toml files into the safety CLI repo.
Summary by CodeRabbit
New Features
PYPROJECT_TOML
files in addition to existing file types.Style