Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngr: Add as dedicated install extra, pip install pueblo[ngr] #145

Merged
merged 3 commits into from
Jan 19, 2025
Merged

ngr: Add as dedicated install extra, pip install pueblo[ngr] #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3d4390
ngr: Add as dedicated install extra, `pip install pueblo[ngr]`
amotl Jan 18, 2025
e0a1aaa
Dependencies: `tomli` is already part of the baseline requirements
amotl Jan 19, 2025
72be215
Chore: Fix links after merging branch `sfa`
amotl Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Unreleased
- ngr: For invoking Elixir, use `mix test --trace`
- ngr: Added as dedicated install extra, `pip install pueblo[ngr]`
- Testing: Unlocked compatibility with pytest version 8
- SFA: Added a subsystem for loading single-file applications

Expand Down
2 changes: 1 addition & 1 deletion pueblo/sfa/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ not be used together.
# Invoke Python entrypoint with given specification.
PYTHONPATH=$(pwd) sfa run tests.testdata.entrypoint:main
sfa run tests/testdata/entrypoint.py:main
sfa run https://github.com/pyveci/pueblo/raw/refs/heads/sfa/tests/testdata/entrypoint.py#main
sfa run https://github.com/pyveci/pueblo/raw/refs/heads/main/tests/sfa/basic.py#main
sfa run github://pyveci:pueblo@/tests/testdata/entrypoint.py#main
```

Expand Down
8 changes: 5 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ dependencies = [
]

optional-dependencies.all = [
"pueblo[cli,dataframe,fileio,nlp,notebook,proc,sfa-full,testing,web]",
"pueblo[cli,dataframe,fileio,ngr,nlp,notebook,proc,sfa-full,testing,web]",
]
optional-dependencies.cli = [
"click<9",
Expand Down Expand Up @@ -97,6 +97,10 @@ optional-dependencies.fileio = [
"s3fs>=2021",
"yarl<1.19",
]
optional-dependencies.ngr = [
"pip",
"pueblo[cli]",
]
optional-dependencies.nlp = [
"aiohttp<3.12",
"langchain>=0.1,<0.4",
Expand All @@ -118,13 +122,11 @@ optional-dependencies.release = [
]
optional-dependencies.sfa = [
"pueblo[cli]",
"tomli<3",
]
optional-dependencies.sfa-full = [
"fsspec[github,http,libarchive,s3]<2024.11",
"instld<0.1",
"pueblo[sfa]",
"tomli<3",
]
optional-dependencies.test = [
"pueblo[testing]",
Expand Down
4 changes: 2 additions & 2 deletions tests/test_sfa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def test_address_url():
[
"tests.sfa.basic:main",
"tests/sfa/basic.py:main",
"https://github.com/pyveci/pueblo/raw/refs/heads/sfa/tests/sfa/basic.py#main",
"https://github.com/pyveci/pueblo/raw/refs/heads/main/tests/sfa/basic.py#main",
],
)
def test_application_api_success(capsys, spec):
Expand Down Expand Up @@ -73,7 +73,7 @@ def test_application_api_not_callable(capsys, spec):
[
"tests.sfa.basic:main",
"tests/sfa/basic.py:main",
"https://github.com/pyveci/pueblo/raw/refs/heads/sfa/tests/sfa/basic.py#main",
"https://github.com/pyveci/pueblo/raw/refs/heads/main/tests/sfa/basic.py#main",
],
)
def test_application_cli(mocker, capfd, spec):
Expand Down
Loading