ngr: Fix Gradle test runner by wiping existing gradlew Gradle wrapper
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aims to accommodate for contemporary versions of Java, where older versions of shipped Gradle wrappers would fail on.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
=======================================
Coverage 88.65% 88.66%
=======================================
Files 19 19
Lines 626 635 +9
=======================================
+ Hits 555 563 +8
- Misses 71 72 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
amotl
changed the title
gradlew Gradle wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Fixing ngr's Gradle outlet once more aims to accommodate for contemporary versions of Java, where older versions of shipped Gradle wrappers would fail on:
Unsupported class file major version 65and friends.Coming from GH-37, this patch attempts to resolve the problem by trying another heuristic, which will prefer wiping an existing
gradlewwrapper script, if there is a chance that a new one can be generated, i.e. when thegradleprogram is installed on the system.Otherwise, ngr will emit a corresponding error message:
Testdrive