Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the Rotation.from_euler() API #223

Merged
merged 4 commits into from
Sep 6, 2021

Conversation

pc494
Copy link
Member

@pc494 pc494 commented Sep 5, 2021

Description of the change

See discussion in #215

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the
    unreleased section in CHANGELOG.rst.

close #215

@pc494 pc494 requested a review from hakonanes September 5, 2021 14:09
@pc494 pc494 mentioned this pull request Sep 5, 2021
3 tasks
Copy link
Member

@hakonanes hakonanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that we can remove code but not functionality! I just have a couple questions I would like answered if you find the time.

@hakonanes hakonanes changed the title cleaning up .from_euler() syntax Simplify the Rotation.from_euler() API Sep 5, 2021
@hakonanes hakonanes added the documentation Relates to the documentation label Sep 5, 2021
@hakonanes hakonanes added this to the v0.7.0 milestone Sep 5, 2021
@hakonanes hakonanes merged commit add9c2a into pyxem:master Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Streamline the from_euler method to better work with MTEX
2 participants