Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python version compatibility to range 3.10-12 #521

Merged
merged 13 commits into from
Sep 18, 2024

Conversation

hakonanes
Copy link
Member

@hakonanes hakonanes commented Sep 17, 2024

Description of the change

Remove explicit compatibility for Python 3.8 and 3.9 and add it for 3.12. Fixes #515.

Test suite on CI is updated to use 3.11 and 3.12, with one runner for 3.10 and minimal version dependencies.

Bump lowest Matplotlib from >= 3.5 to >= 3.6.1 (skip 3.6.0 as it throws a gazillion+1 MatplotlibDeprecationWarnings).

Other changes:

  • Remove unnecessary UTF-8 encoding for all files
  • Remember to update changelog
  • Ensure 100% test coverage with all dependencies installed (mention this in test dev guide)
  • Remove do_3d_projection() in our minimal Arrow3D class as it seems (!) to be unnecessary with Matplotlib >= 3.6.1 Turned out to still be necessary.
  • Update Matplotlib tests following >= 3.6.1

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • Contributor(s) are listed correctly in __credits__ in orix/__init__.py and in
    .zenodo.json.

@hakonanes hakonanes added dev Package maintenance tests Relates to the tests labels Sep 17, 2024
@hakonanes hakonanes added this to the v0.13.1 milestone Sep 17, 2024
Copy link
Member

@pc494 pc494 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, happy for you to merge.

@hakonanes hakonanes merged commit 3e31b35 into pyxem:develop Sep 18, 2024
12 checks passed
@hakonanes hakonanes deleted the remove-python38-39-compat branch September 18, 2024 15:39
@hakonanes
Copy link
Member Author

Thanks for the swift review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Package maintenance tests Relates to the tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip compatibility with Python 3.8 and 3.9?
2 participants