- Fix RunEmrJob#isEquivalentTo()

- Fix KeyValue#extendMap() Signed-off-by: Benjamin Rögner <[email protected]>
qGYdXbY2 · Jan 10, 2025 · d9f1f51 · d9f1f51
1 parent 256a40b
commit d9f1f51
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/xyz-jobs/xyz-job-steps/src/main/java/com/here/xyz/jobs/steps/execution/RunEmrJob.java b/xyz-jobs/xyz-job-steps/src/main/java/com/here/xyz/jobs/steps/execution/RunEmrJob.java
@@ -204,13 +204,13 @@ public boolean isEquivalentTo(StepExecution other) {
         //TODO: For now do not compare the actual values of the positional params until the full fledged inputSet comparison was implemented for the GraphFusion
         && Objects.equals(otherEmrStep.positionalScriptParams.size(), positionalScriptParams.size())
         //TODO: For now do not compare the actual values of the positional that contain an inputSet reference until the full fledged inputSet comparison was implemented for the GraphFusion
-        && Objects.equals(otherEmrStep.namedScriptParams, namedScriptParams)
+        && isEquivalentTo(namedScriptParams, otherEmrStep.namedScriptParams)
         && Objects.equals(otherEmrStep.sparkParams, sparkParams);
   }
 
   private boolean isEquivalentTo(Map<String, String> namedScriptParams, Map<String, String> otherNamedScriptParams) {
     return Objects.equals(namedScriptParams.keySet(), otherNamedScriptParams.keySet()) &&
-        namedScriptParams.entrySet().stream()
+        namedScriptParams != null && otherNamedScriptParams != null && namedScriptParams.entrySet().stream()
             .allMatch(entry -> isEquivalentTo(namedScriptParams.get(entry.getKey()), otherNamedScriptParams.get(entry.getKey())));
   }
 

diff --git a/xyz-models/src/main/java/com/here/xyz/util/KeyValue.java b/xyz-models/src/main/java/com/here/xyz/util/KeyValue.java
@@ -30,7 +30,7 @@ public KeyValue<K, V> putToMap(Map<K, V> map) {
   }
 
   public Map<K, V> extendMap(Map<K, V> map) {
-    Map<K, V> extended = new HashMap<>();
+    Map<K, V> extended = new HashMap<>(map);
     putToMap(extended);
     return extended;
   }