Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store search history #22208

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Store search history #22208

merged 1 commit into from
Jan 30, 2025

Conversation

glassez
Copy link
Member

@glassez glassez commented Jan 26, 2025

20250126_193059

20250126_192513

@glassez glassez added Search engine Issues related to the search engine/search plugins functionality GUI GUI-related issues/changes labels Jan 26, 2025
@glassez glassez requested a review from a team January 26, 2025 16:33
src/gui/search/searchwidget.cpp Outdated Show resolved Hide resolved
src/gui/search/searchwidget.cpp Outdated Show resolved Hide resolved
src/gui/search/searchwidget.cpp Outdated Show resolved Hide resolved
src/gui/search/searchwidget.cpp Outdated Show resolved Hide resolved
src/gui/search/searchwidget.cpp Outdated Show resolved Hide resolved
src/gui/search/searchwidget.cpp Show resolved Hide resolved
src/gui/search/searchwidget.cpp Show resolved Hide resolved
@thalieht
Copy link
Contributor

Dunno if these matter:

  1. Sorting in the list goes like this:
    1
    11
    2
    ...
  2. Decreasing the search history length only applies after qBt restart.

@xavier2k6
Copy link
Member

This will help close below:

@glassez glassez force-pushed the search-history branch 3 times, most recently from 529166a to 2861156 Compare January 28, 2025 07:04
@glassez
Copy link
Member Author

glassez commented Jan 28, 2025

  1. Sorting in the list goes like this:
    1
    11
    2
    ...
  2. Decreasing the search history length only applies after qBt restart.

Should be fixed now.

@glassez glassez requested a review from a team January 28, 2025 07:06
@glassez glassez added this to the 5.1 milestone Jan 28, 2025
@thalieht
Copy link
Contributor

  1. Sorting in the list goes like this:
    1
    11
    2
    ...

Should be fixed now.

Nope:
z1
z11
z2
...

@glassez
Copy link
Member Author

glassez commented Jan 28, 2025

Nope:

Did you try some clear case, like z1, z5, z3, z4, z2? It wasn't sorted before.

z1
z11
z2

I believe it is "usual" string sort order (standard Qt sorting model produce it).
Do you want me to apply so-called "natural" sorting?

@thalieht
Copy link
Contributor

Did you try some clear case, like z1, z5, z3, z4, z2? It wasn't sorted before.

I did try and it seemed sorted to me except what i said (not completely sure i remember it right). I mean if it was random i would just assume there is no sorting and wouldn't say anything.

I believe it is "usual" string sort order (standard Qt sorting model produce it).
Do you want me to apply so-called "natural" sorting?

If you're asking what i personally want, i don't care if there is any sorting. But to me it makes sense to use natural sorting if there is.

@glassez
Copy link
Member Author

glassez commented Jan 28, 2025

But to me it makes sense to use natural sorting if there is.

Well. Done.

@Piccirello
Copy link
Member

Is there a way to clear the history? Either completely or individual items

@glassez
Copy link
Member Author

glassez commented Jan 29, 2025

Is there a way to clear the history? Either completely or individual items

Currently you can temporarily set history size to 0 in order to clear it.

@glassez glassez merged commit b76054b into qbittorrent:master Jan 30, 2025
15 checks passed
@glassez glassez deleted the search-history branch January 30, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI GUI-related issues/changes Search engine Issues related to the search engine/search plugins functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants