Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rerankers in FastEmbed #1434

Merged
merged 3 commits into from
Jan 31, 2025
Merged

rerankers in FastEmbed #1434

merged 3 commits into from
Jan 31, 2025

Conversation

mrscoopers
Copy link
Contributor

No description provided.

@mrscoopers mrscoopers requested a review from joein January 28, 2025 14:30
@mrscoopers mrscoopers self-assigned this Jan 28, 2025
Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for condescending-goldwasser-91acf0 ready!

Name Link
🔨 Latest commit 5b01d8d
🔍 Latest deploy log https://app.netlify.com/sites/condescending-goldwasser-91acf0/deploys/679c9e4feb98f70008249ae6
😎 Deploy Preview https://deploy-preview-1434--condescending-goldwasser-91acf0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joein
Copy link
Member

joein commented Jan 29, 2025

Overall looks good, I did not pay attention to how the sentences are written, but focused solely on the meaning, maybe someone else would like to take a look.
Maybe we could mention that the model we are using is under a proprietary license
Also, we might've done a larger prefetch with 50-100 queries, rerank them and take the first 10, but just sorting works fine as well.
Not important, just what caught my eye: we install fastembed and qdrant-client separately, however, it might've been done with pip install "qdrant-client[fastembed]"
Using a named vector seems to be unnecessary (it's ok if u wanted to show how to use them)

@davidmyriel
Copy link
Contributor

@mrscoopers can you just use AI to fix the grammar? I am really out of capacity. You can also ask @maddie-qdrant

@mrscoopers
Copy link
Contributor Author

@mrscoopers can you just use AI to fix the grammar? I am really out of capacity. You can also ask @maddie-qdrant

done

@mrscoopers mrscoopers merged commit a46c3b6 into master Jan 31, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants