Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dbsf zero variance #875

Merged
merged 3 commits into from
Jan 6, 2025
Merged

fix: dbsf zero variance #875

merged 3 commits into from
Jan 6, 2025

Conversation

pavelm10
Copy link
Contributor

@pavelm10 pavelm10 commented Jan 3, 2025

solves #871

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit 5eb765c
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/677bf094cfe5d80008a7a467
😎 Deploy Preview https://deploy-preview-875--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@generall
Copy link
Member

generall commented Jan 3, 2025

python implementation of scoring should follow the original one in qdrant core, and there we do this:

https://github.com/qdrant/qdrant/blob/a0ea3caccff8dd24eab59692233f26974d51d426/lib/segment/src/common/score_fusion.rs#L99

Let's follow the reference implementation in this case

@pavelm10
Copy link
Contributor Author

pavelm10 commented Jan 3, 2025

@generall thanks for review, changed the implementation.

@pavelm10
Copy link
Contributor Author

pavelm10 commented Jan 6, 2025

@generall hi is there anything else to do?

@joein
Copy link
Member

joein commented Jan 6, 2025

Hey @pavelm10
Thanks for the contribution, I think it is pretty much done now

@joein joein self-requested a review January 6, 2025 15:55
@joein joein merged commit dde9cb7 into qdrant:dev Jan 6, 2025
9 checks passed
joein added a commit that referenced this pull request Jan 16, 2025
* fix: dbsf zero variance

solves #871

* review suggestions

* fix: fix dbsf single response score

---------

Co-authored-by: George Panchuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants