Skip to content

Commit

Permalink
make UpdateCollectionClusterSetupRequest.operation required
Browse files Browse the repository at this point in the history
  • Loading branch information
JojiiOfficial committed Jun 26, 2024
1 parent e89b8b6 commit 959e36b
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 16 deletions.
4 changes: 3 additions & 1 deletion src/builder_ext.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
use std::collections::HashMap;

use crate::qdrant::update_collection_cluster_setup_request::Operation;
use crate::qdrant::{
shard_key, AbortShardTransferBuilder, BinaryQuantizationBuilder, ClearPayloadPointsBuilder,
ContextExamplePair, CountPointsBuilder, CreateAliasBuilder, CreateCollectionBuilder,
Expand Down Expand Up @@ -306,9 +307,10 @@ impl DeleteFieldIndexCollectionBuilder {
}

impl UpdateCollectionClusterSetupRequestBuilder {
pub fn new(collection_name: impl Into<String>) -> Self {
pub fn new(collection_name: impl Into<String>, operation: impl Into<Operation>) -> Self {
let mut builder = Self::empty();
builder.collection_name = Some(collection_name.into());
builder.operation = Some(Some(operation.into()));
builder
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/qdrant.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1158,7 +1158,7 @@ pub struct UpdateCollectionClusterSetupRequest {
oneof = "update_collection_cluster_setup_request::Operation",
tags = "2, 3, 4, 5, 7, 8, 9"
)]
#[builder(default, setter(into, strip_option), field(vis = "pub(crate)"))]
#[builder(field(vis = "pub(crate)"))]
pub operation: ::core::option::Option<
update_collection_cluster_setup_request::Operation,
>,
Expand Down
19 changes: 10 additions & 9 deletions src/qdrant_client/collection.rs
Original file line number Diff line number Diff line change
Expand Up @@ -399,15 +399,16 @@ impl Qdrant {
///# async fn update_collection_cluster_setup(client: &Qdrant)
///# -> Result<(), QdrantError> {
/// client
/// .update_collection_cluster_setup(
/// UpdateCollectionClusterSetupRequestBuilder::new("my_collection")
/// .operation(MoveShardBuilder::new(
/// 0, // Shard ID
/// 0, // From peer ID
/// 1, // To peer ID
/// ))
/// )
/// .await?;
/// .update_collection_cluster_setup(UpdateCollectionClusterSetupRequestBuilder::new(
/// "my_collection",
/// MoveShardBuilder::new(
/// 0, // Shard ID
/// 0, // From peer ID
/// 1, // To peer ID
/// )
/// .build(),
/// ))
/// .await
///# Ok(())
///# }
/// ```
Expand Down
7 changes: 6 additions & 1 deletion tests/builder_coverage.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
use std::collections::HashMap;

use qdrant_client::qdrant::update_collection_cluster_setup_request::Operation;
use qdrant_client::qdrant::{
AbortShardTransferBuilder, BinaryQuantizationBuilder, ClearPayloadPointsBuilder,
ContextInputBuilder, ContextInputPairBuilder, CountPointsBuilder, CreateAliasBuilder,
Expand Down Expand Up @@ -58,7 +59,11 @@ fn builder_coverage() {
UpsertPointsBuilder::new("my_collection", []).build();
CreateFieldIndexCollectionBuilder::new("my_collection", " myfield", FieldType::Integer).build();
DeleteFieldIndexCollectionBuilder::new("my_collection", " myfield").build();
UpdateCollectionClusterSetupRequestBuilder::new("my_collection").build();
UpdateCollectionClusterSetupRequestBuilder::new(
"my_collection",
Operation::MoveShard(MoveShardBuilder::new(0, 0, 0).build()),
)
.build();
MoveShardBuilder::new(0, 0, 0).build();
ReplicateShardBuilder::new(0, 0, 0).build();
ReplicaBuilder::new(0, 0).build();
Expand Down
5 changes: 1 addition & 4 deletions tests/protos.rs
Original file line number Diff line number Diff line change
Expand Up @@ -612,10 +612,7 @@ fn configure_builder(builder: Builder) -> Builder {
"UpdateCollectionClusterSetupRequest.timeout",
DEFAULT_OPTION,
),
(
"UpdateCollectionClusterSetupRequest.operation",
DEFAULT_OPTION_INTO,
),
("UpdateCollectionClusterSetupRequest.operation", PUBLIC_ONLY),
// MoveShard
("MoveShard.shard_id", PUBLIC_ONLY),
("MoveShard.to_shard_id", DEFAULT_OPTION),
Expand Down

0 comments on commit 959e36b

Please sign in to comment.