Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor impl blocks for grpc types [1] #101

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Refactor impl blocks for grpc types [1] #101

merged 2 commits into from
Apr 25, 2024

Conversation

JojiiOfficial
Copy link
Contributor

Puts existing From<> conversions and the PointStruct constructor into a separate file

@JojiiOfficial JojiiOfficial changed the title Refactor impl blocks for grpc types Refactor impl blocks for grpc types [1] Apr 25, 2024
timvisee
timvisee approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@timvisee timvisee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I like grpc_ext, but to be honest, I don't have a better suggestion 😄

@timvisee timvisee mentioned this pull request Apr 25, 2024
Closed
9 tasks
@JojiiOfficial
Copy link
Contributor Author

Yeah I agree 😄

@JojiiOfficial JojiiOfficial merged commit 108ef6d into dev Apr 25, 2024
2 checks passed
@JojiiOfficial JojiiOfficial deleted the refactor_grpc_extensions branch May 1, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvisee timvisee timvisee approved these changes

@generall generall Awaiting requested review from generall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JojiiOfficial @timvisee