Finish collection builder #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JojiiOfficial
force-pushed
the
finish_collection_builder
branch
from
7515c43 to
402630d
Compare
JojiiOfficial
force-pushed
the
finish_collection_builder
branch
from
402630d to
8294725
Compare
timvisee
approved these changes
May 2, 2024
Comment on lines
+34
to
+35
| .vectors_config(VectorParamsBuilder::new(300, Distance::Cosine)) | ||
| .quantization_config(ScalarQuantizationBuilder::new(QuantizationType::Int8)) |
There was a problem hiding this comment.
@generall what is your opinion on this; having some required parameters in new()?
I think it is fine. But we'd have to make sure all parameters we add in the future are optional, otherwise it would fail to compile again.
And this better than a runtime panic for missing fields.
There was a problem hiding this comment.
Yeah, we discussed it in slack briefly. I think having ::new with required params is better
Merged
|
I think this can be merged 😄 |
timvisee
pushed a commit
that referenced
this pull request
Jun 27, 2024
* add more builder; add extra constructor for builder with required fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #108
Defaultfor builder with required fields and adds a custom constructor to them