Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constant CI failures with protobuf installation, match core repo #157

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

timvisee
Copy link
Member

We had constant CI errors due to inconsistent protobuf versions.

This updates our CI to use the same way of installing protobuf related dependencies as we do in the core repository here: https://github.com/qdrant/qdrant/blob/5c29cad76edc4fe33882d385c02633352666d67e/.github/workflows/rust.yml#L24-L27

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

@timvisee timvisee merged commit c35980a into dev Jun 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant