Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose builders module #159

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Expose builders module #159

merged 1 commit into from
Jun 28, 2024

Conversation

JojiiOfficial
Copy link
Contributor

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@JojiiOfficial JojiiOfficial changed the base branch from master to dev June 28, 2024 09:01
@JojiiOfficial JojiiOfficial force-pushed the expose_builders_module branch from ae06cc1 to d37a598 Compare June 28, 2024 09:03
Comment on lines 41 to +46
append_to_file(GRPC_OUTPUT_FILE, "pub use crate::manual_builder::*;");
append_to_file(GRPC_OUTPUT_FILE, "pub use crate::builder_types::*;");
append_to_file(
GRPC_OUTPUT_FILE,
"pub use crate::qdrant_client::builders::*;",
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should improve on this eventually. Right now each of them reopens and re-appends the file. But we can do that later.

@JojiiOfficial JojiiOfficial merged commit 34ff45b into dev Jun 28, 2024
2 checks passed
timvisee pushed a commit that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants