Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protocol definitions for Qdrant 1.13 #208

Merged
merged 7 commits into from
Jan 16, 2025
Merged

Update protocol definitions for Qdrant 1.13 #208

merged 7 commits into from
Jan 16, 2025

Conversation

timvisee
Copy link
Member

@timvisee timvisee commented Jan 15, 2025

Update the protocol definitions and all related structures to match our upcoming Qdrant release.

This adds quite a few builders for new types, and makes the necessary changes to glue everything together (with minimal breakage).

It excludes builders and integrations for the new inference API types such as Document and Object. Those will be implemented once we actually release the feature.

Example of reworked max optimization threads interface in documentation, also supporting the previous raw number:

image

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@timvisee timvisee changed the title WIP: update for Qdrant 1.13 Update for Qdrant 1.13 Jan 15, 2025
@timvisee timvisee requested a review from agourlay January 15, 2025 15:11
@timvisee timvisee changed the title Update for Qdrant 1.13 Update protocol definitions for Qdrant 1.13 Jan 15, 2025
@timvisee timvisee requested a review from ffuugoo January 15, 2025 15:15
@timvisee timvisee marked this pull request as ready for review January 15, 2025 15:16
Copy link
Member

@agourlay agourlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have validated this branch by using it in coach and crasher.
Everything looks good 👍

@timvisee
Copy link
Member Author

Merging this so I can prepare the release PR

@timvisee timvisee merged commit f2c3883 into dev Jan 16, 2025
2 checks passed
timvisee added a commit that referenced this pull request Jan 16, 2025
* Update gRPC protocol buffer definitions

* Generate gRPC types, update builders and conversions

* Add max optimization threads builder

* Add bool index params builder

* Add has vector condition builder

* Add dense, sparse and multi dense vector builders and conversions

* Remove has vector condition builder, follow pattern of other conditions
@timvisee timvisee mentioned this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants