Ergonomic Payload::deserialize
(unoptimised version)
#58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #37, #37 (comment), and #37 (comment).
This PR enables library users to utilize the straightforward method
Payload::deserialize(self)
to deserialize a payload into any typeT
, as long asT
implementsserde::de::DeserializeOwned
.The current approach carries significant overhead as it initially serializes a payload into
serde_json::Value
and then deserializes it back.One possible solution to mitigate this overhead could be the use of
MapDeserializer
(see more). However, this would require implementingIntoDeserializer
forqdrant::Value
, something which I was unable to accomplish.