Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose all parameters in collection update #77

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

timvisee
Copy link
Member

@timvisee timvisee commented Nov 10, 2023

Fixes #75.

In Qdrant client 1.6, our update_collection function does not expose all parameters. Instead, it only supports updating the optimizer configuration.

This PR adds all the other parameters to expose them in Qdrant client 1.7.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

@timvisee timvisee marked this pull request as draft November 10, 2023 12:47
@timvisee timvisee marked this pull request as ready for review November 10, 2023 14:14
@generall generall force-pushed the extend-update-collection branch from e392343 to c70dee1 Compare December 6, 2023 19:37
@timvisee timvisee force-pushed the extend-update-collection branch from 021bc62 to 4aed108 Compare December 7, 2023 10:21
@timvisee timvisee merged commit 531c891 into dev Dec 7, 2023
2 checks passed
timvisee added a commit that referenced this pull request Dec 7, 2023
* Add `update_collection_extended`

* Update `update_collection` to `update_collection_extended`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants