Bump outdated deps #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvisee
approved these changes
Apr 19, 2024
agourlay
reviewed
Apr 19, 2024
Cargo.toml
Outdated
| anyhow = "1" | ||
|
|
||
| serde = { version = "1", features = ["derive"], optional = true } | ||
| serde_json = { version = "1", optional = true } | ||
| reqwest = { version = "0.11.24", optional = true, default-features = false, features = ["stream", "rustls-tls"] } | ||
| reqwest = { version = "0.12.3", optional = true, default-features = false, features = ["stream", "rustls-tls"] } |
There was a problem hiding this comment.
reqwest 0.12.0 has extracted the http2 module in a dedicated feature which is enabled by default.
This diff means that we would not support http2 anymore for our REST calls.
I believe it should be reactivated.
There was a problem hiding this comment.
but do we really need it? cargo build --all-features compiles fine without "http2" and "rustls-tls" features.
There was a problem hiding this comment.
While we don't strictly need it, I think its better to enable. The server side of things - which reqwest connects to - supports it as well. So we may as well benefit from it there.
timvisee
approved these changes
Apr 22, 2024
agourlay
approved these changes
Apr 22, 2024
generall
pushed a commit
that referenced
this pull request
Apr 22, 2024
* update deps * add http2 feature to reqwest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the dependencies that have newer versions available.
Was there a reason to keep them pinned to their current version?