base class #56
Merged
base class #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jstucke
commented
Feb 19, 2024
•
jstucke
commented
- introduces base classes to remove duplicate code from individual servers
- some refactoring:
- moved template code from http[s] servers into files
- moved common methods from servers to helper module
- removed some unused code
- several bug fixes
- http/https: fixed comparison bug
- imap: fixed missing imports
- smb: fixed parsing / logging bug
- ssh:
- fixed timeout error in "interactive" mode
- fixed type error bugs
- vnc:
- fixed pw decoding
- fixed wordlist loading
- fixed status logging bug
* removed duplicate code * added new base class for http servers * moved html template code to files * removed unused code * some refacoring
Base class
reduce code duplication + bug fixes
code duplication II
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.