Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update georeferencer.rst #9402

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Update georeferencer.rst #9402

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bacdbc
Update georeferencer.rst
crayfish66 Nov 22, 2024
b6bae5a
Move tips
DelazJ Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions docs/user_manual/working_with_raster/georeferencer.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ you can accurately determine coordinates.
+--------------------------------+------------------------------+-------------------------------+----------------------------+
| |saveGCPPointsAs| | Save GCP Points As | |transformSettings| | Transformation settings |
+--------------------------------+------------------------------+-------------------------------+----------------------------+
| |addGCPPoint| | Add Point | |deleteGCPPoint| | Delete Point |
| |addGCPPoint| | Add GCP Point | |deleteGCPPoint| | Delete GCP Point |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with QGIS interface, would you want to fix these also in the software? The place to start the update is https://github.com/qgis/QGIS/blob/master/src/ui/georeferencer/qgsgeorefpluginguibase.ui#L240. Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never worked with the software itself, so I'm afraid to make some mess. For the time being I've no time to get familiar with the procedures, so either it would have to wait some time or I'll have to ask for your help in this. Cheers.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem @crayfish66. Done at qgis/QGIS#59598

+--------------------------------+------------------------------+-------------------------------+----------------------------+
| |moveGCPPoint| | Move GCP Point | |pan| | Pan |
+--------------------------------+------------------------------+-------------------------------+----------------------------+
Expand Down Expand Up @@ -70,7 +70,7 @@ The usual procedure for georeferencing an image involves selecting multiple
points on the raster, specifying their coordinates, and choosing a relevant
transformation type. Based on the input parameters and data, the Georeferencer will
compute the world file parameters. The more coordinates you provide, the better
the result will be.
the result will be. After you provide a few points, you can use the |linkQGisToGeoref| "Link QGIS to Georeferencer" and/or |linkGeorefToQGis| "Link Georeferencer to QGIS" buttons that will adjust, respectively, the map extent of the main QGIS window to the present view in Georeferencer and/or vice versa.

The first step is to start QGIS and click on :menuselection:`Layer -->` |georefRun|
:menuselection:`Georeferencer`, which appears in the QGIS menu bar. The Georeferencer
Expand Down Expand Up @@ -146,6 +146,9 @@ manage the files.

.. _`georeferencer_transformation`:

Tip: to avoid constant switching between a "hand" (Pan) and "Add / Move GCP point" buttons, you may use the keyboard arrow keys for moving and the mouse wheel for scaling the georeferenced map conveniently.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the dedicated tool for tips, providing the corresponding formatting

Suggested change
Tip: to avoid constant switching between a "hand" (Pan) and "Add / Move GCP point" buttons, you may use the keyboard arrow keys for moving and the mouse wheel for scaling the georeferenced map conveniently.
.. tip::
To avoid constant switching between a "hand" (Pan) and "Add / Move GCP point" buttons,
you may use the keyboard arrow keys for moving and the mouse wheel for scaling the georeferenced map conveniently.

BUT there shouldn't be text between an anchor (.. _sometext:) and its title. And since we provide a step-by-step instruction in the section above, how about moving that tip, e.g, somewhere around step 3 or 4 above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm rather new to the QGIS (at least to using it hands-on) so I'm not aware, that some other type of the manual exists (the one I made the additions to also seem a 'step-by-step' type). Where the alternative version is to be found?
And, generally, feel free to place these additions where you know they would be most useful - as a newbie I might not find the really best place (these were where I was looking for them). Best,
WP

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK @crayfish66. There is no other place we describe this tool. By step-by-step, I meant the section under "Entering ground control points (GCPs)". Anyway, I pushed the suggested changes as you asked.
Thanks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah... I didn't mention but let me know if you are OK with these changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, thank you, @DelazJ !



Defining the transformation settings
....................................

Expand Down