Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback improvements #174

Merged
merged 3 commits into from
Feb 22, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/community/involve.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ sidebar: true
{{< content-start >}}
## Ways of Contributing

[Participate in Support Channels](#participate-in-support-channels "scroll-on-page"), [Report Bugs](#report-bugs "scroll-on-page"), [QGIS Documentation](#qgis-documentation "scroll-on-page"), [Translate QGIS](#translate-qgis "scroll-on-page"), [Develop a Plugin](#develop-a-plugin "scroll-on-page"), [Develop QGIS Core](#develop-qgis-core "scroll-on-page"), [Sustain & Donate](#sustain--donate "scroll-on-page")
[Participate in Support Channels](#participate-in-support-channels "scroll-on-page") [Report Bugs](#report-bugs "scroll-on-page") [QGIS Documentation](#qgis-documentation "scroll-on-page") [Translate QGIS](#translate-qgis "scroll-on-page") [Develop a Plugin](#develop-a-plugin "scroll-on-page") [Develop QGIS Core](#develop-qgis-core "scroll-on-page") [Sustain & Donate](#sustain--donate "scroll-on-page")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing commas between links in the list of ways to contribute improves readability and visual appeal. Verify the list's readability and navigability post-change to ensure it aligns with the project's documentation standards and enhances the user experience.


{{< rich-box layoutClass="has-right rounded" >}}
{{< rich-content themeClass="coloring-1" >}}
Expand Down
2 changes: 1 addition & 1 deletion content/download/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ url: '/download'

{{< rich-box mode="html" layoutClass="has-right" id="donate-prompt">}}
{{< rich-content themeClass="coloring-2" >}}
## Support us
## Before download starts

QGIS is free of charge, and will always be free of charge if downloaded from QGIS.org.

Expand Down
92 changes: 92 additions & 0 deletions content/goodies.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
---
type: "page"
title: "Diversity statement"
subtitle: ""
draft: false
sidebar: true
---

{{< content-start >}}


Goodies
===========================================

If you are a fan of QGIS, you might want to visit our store so you can buy some momentos to show off your favourite desktop GIS. We have a number of great t-shirts, mugs, hoodies, caps and so on so pay a visit to one of our stores below!

Buying QGIS apparel not only lets you show off the fact that you use QGIS, for every t-shirt sold a commission is given to the QGIS project.


{{< columns-start >}}
{{< column-start class="is-flex-direction-column is-one-third">}}
## Spreadshirt
We co-operate with Spreadshirt. They produce locally and ship the products to all countries in the world.

[https://shop.spreadshirt.net/qgis/](https://shop.spreadshirt.net/qgis/)

{{< column-end >}}

{{< column-start class="is-flex-direction-column is-two-thirds">}}
{{< columns-start >}}
{{< column-start>}}
![QGIS hoodie](img/contributors/hoodie.jpg)
{{< column-end>}}
{{< column-start>}}
![QGIS tshirt](img/contributors/qgis-heart-logo.jpg)
{{< column-end>}}
{{< columns-end >}}

{{< columns-start >}}
{{< column-start>}}
![QGIS mugs](img/contributors/qgis-q-logo.jpg)
{{< column-end >}}
{{< column-start>}}
![QGIS thermos](img/contributors/thermos.jpg)
{{< column-end >}}
{{< column-start>}}
![QGIS sign](img/contributors/qgis-q.jpg)
{{< column-end>}}
{{< columns-end >}}

{{< column-end >}}
{{< columns-end >}}




{{< columns-start >}}
{{< column-start class="is-flex-direction-column is-one-third">}}
## Redbubble
Some more creative and funny (but unofficial) designs can be found in the Red Bubble store.

[https://www.redbubble.com/shop/qgis](https://www.redbubble.com/shop/qgis)

{{< column-end >}}

{{< column-start class="is-flex-direction-column is-two-thirds">}}
{{< columns-start >}}
{{< column-start>}}
![QGIS hoodie](img/contributors/redbubble1.jpg)
{{< column-end>}}
{{< column-start>}}
![QGIS tshirt](img/contributors/redbubble2.jpg)
{{< column-end>}}
{{< columns-end >}}

{{< columns-start >}}
{{< column-start>}}
![QGIS mugs](img/contributors/redbubble3.jpg)
{{< column-end >}}
{{< column-start>}}
![QGIS thermos](img/contributors/redbubble4.jpg)
{{< column-end >}}
{{< column-start>}}
![QGIS sign](img/contributors/redbubble5.jpg)
{{< column-end>}}
{{< columns-end >}}

{{< column-end >}}
{{< columns-end >}}


{{< content-end >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of a "Diversity statement" and promotion of QGIS merchandise is well-structured and enhances community engagement. Ensure all images have descriptive alt text for accessibility. Also, verify that external links to merchandise stores are accessible and reliable to maintain a positive user experience.

3 changes: 3 additions & 0 deletions static/img/addsupporter.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/img/contributors/hoodie.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/img/contributors/qgis-heart-logo.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/img/contributors/qgis-q-logo (1).jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/img/contributors/qgis-q-logo.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/img/contributors/qgis-q.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/img/contributors/redbubble1.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/img/contributors/redbubble2.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/img/contributors/redbubble3.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/img/contributors/redbubble4.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/img/contributors/redbubble5.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added static/img/contributors/thermos.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@
img
filter: grayscale(1)

.add-supporter
a
text-align: center
color: #002033
Comment on lines +47 to +50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new style for .add-supporter a selector improves visual consistency. Verify that the color contrast of #002033 meets accessibility standards for text against its background. Also, ensure this style aligns with the project's overall design system for a cohesive user experience.


.supporters-grid
.large-supporter
border-radius: 10px
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@
margin: 0

@media screen and (max-width: 1023px)
.content
>.columns >.is-3
padding: 0
.sidebar
background: #fff
border-radius: 10px
Expand All @@ -110,6 +113,7 @@
position: relative
z-index: 3
border-radius: 10px
margin-left: 0.75rem
max-width: fit-content

&.open
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ $container-max-width: $fullhd !default
// padding-left: $gap
// padding-right: $gap
width: 100%
+tablet
max-width: $tablet - $container-offset
Comment on lines +16 to +17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of a max-width for tablets enhances the responsiveness of the container element. Ensure that the $container-offset and $tablet variables are consistently defined and used across the project to maintain styling consistency and readability.

+desktop
max-width: $desktop - $container-offset
+until-widescreen
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ $dimensions: 16 24 32 48 64 96 128 !default
img
display: block
height: auto
width: 100%
&.is-rounded
border-radius: $radius-rounded
&.is-fullwidth
Expand Down
23 changes: 15 additions & 8 deletions themes/hugo-bulma-blocks-theme/assets/sass/bulma/layout/hero.sass
Original file line number Diff line number Diff line change
Expand Up @@ -171,19 +171,23 @@ $hero-colors: $colors !default
flex-shrink: 0
padding: $hero-body-padding
+mobile
padding: $hero-body-padding-v-large
height: 100vh
min-height: 840px
display: flex

.container
margin: auto
@media screen and (max-width: 769px)
display: flex
flex-direction: column-reverse
.image
margin: auto
.column
@media screen and (max-width: 1024px)
width: 100%
.logo
@media screen and (max-width: 1024px)
display: none
padding: 0rem
.scroll-down
margin-top: 9rem
@media screen and (min-width: 769px)
Expand All @@ -199,18 +203,21 @@ $hero-colors: $colors !default
padding: 3rem 0;

.hero
image
img
max-height: 380px
@media screen and (max-width: 769px)
max-height: 220px
.title:not(.is-spaced) + .subtitle
margin-top: 0px
.button
margin-right: 2.5rem
.hero-container
margin-bottom: 60px
.label
background: $warning;
display: inline-block;
padding: 5px 15px;
font-weight: 400;
border-radius: 100px;
border: 2px solid #ee7914
color: white
display: inline-block
padding: 5px 15px
font-weight: 400
border-radius: 100px

13 changes: 13 additions & 0 deletions themes/hugo-bulma-blocks-theme/assets/sass/style.sass
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@ h2
@media screen and (max-width: 768px)
font-size: 2.25rem

@media screen and (max-width: 1024px)
.content
>.columns
display: block
.content
width: 100%

.alpha70
opacity: 70%

Expand Down Expand Up @@ -393,6 +400,12 @@ h2

.scroll-on-page
font-size: 14px
padding: 3px 12px
margin: 0 2px 5px 0px
display: inline-block
text-wrap: nowrap
border-radius: 30px
background: #58963217
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The styling added for .scroll-on-page elements introduces several properties including padding, margin, display, text-wrap, border-radius, and background color. This styling enhances the visual appeal and readability of scroll-on-page elements, making them more distinct and easier to interact with. However, the text-wrap: nowrap; property might not be valid CSS. The correct property for preventing text wrapping is white-space: nowrap;.

-  text-wrap: nowrap
+  white-space: nowrap

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
padding: 3px 12px
margin: 0 2px 5px 0px
display: inline-block
text-wrap: nowrap
border-radius: 30px
background: #58963217
padding: 3px 12px
margin: 0 2px 5px 0px
display: inline-block
white-space: nowrap
border-radius: 30px
background: #58963217


.left-title
padding-right: 4rem
Expand Down
7 changes: 0 additions & 7 deletions themes/hugo-bulma-blocks-theme/layouts/partials/banner.html
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,6 @@ <h1 class="title hero-title pr-3">
</figure>
</div>
{{ end }}
<div
class="scroll-down is-flex is-justify-content-center"
>
<figure>
<img src="{{ absURL "img/scroll-down.svg" }}" />
</figure>
</div>
</div>
</section>
{{ end }}
Original file line number Diff line number Diff line change
@@ -1,10 +1,23 @@
<section class="section">
<div class="container">
<h2 class="pb-2">
QGIS supporters
</h2>

<div class="pb-2">
<h2>
QGIS supporters
</h2>
</div>
<div class="supporters-grid large-grid">
<div class="large-supporter is-vertical is-flex fund-Flagship add-supporter">
<article class="tile is-child box is-transparent is-flex is-justify-content-center is-align-items-center">
<a href="/community/members/sustaining_member/">
<figure>
<img src="{{ .Site.BaseURL }}/img/addsupporter.svg" alt="add supporter">
</figure>
</a>
</article>
<a class="partner-title" href="/community/members/sustaining_member/">
Add your logo here?
</a>
</div>
Comment on lines +3 to +20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The restructuring of the "QGIS supporters" section with a clearer heading and an option to add logos is a positive change. Ensure semantic HTML practices are followed, including the use of appropriate headings and accessible links. Also, verify the visual and functional integration of the new supporter block with the existing layout, ensuring it enhances user engagement without compromising accessibility.

{{ $.Scratch.Set "counter" 0 }}
{{ $headlessbundle := .Site.GetPage "/funders" }}
{{ range ( $headlessbundle.Resources.ByType "page" ) }}
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<button class="button is-info is-inverted" id="hide-donate-prompt" onclick="hidePrompt()">I don’t want to participate</button>
<button class="button is-primary6" id="hide-donate-prompt" onclick="hidePrompt()">Skip it and go to download</button>
Loading