-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GxGSV NMEA 4.10 - Add Signal averaging - Update gpsinformationwidget #58357
base: master
Are you sure you want to change the base?
Conversation
NMEA RMC - Set qualitydescription only for status: A or V in processRmcSentence NMEA GSV - Add Signal averaging processGsvSentence
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist. |
@nyalldawson Ciao The change to GxGSV is a simple adaptation to NMEA 4.10 The change to GxRMC solves a problem with the new Unicore UM98x receivers, low-cost GNSS receivers that are having a considerable success on par with the UBlox F9P. The current procedure in QGIS only checks Status=A to fix from the Mode flag: passing to Void any other value of Status and then: It should be noted that A next step for NMEA: |
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
Update for Status not A, V - for UM982 Status = D - Differential when it becomes RTKfix
@nyalldawson test Windows Qt6 builds UNICORE UM982 |
very good, test done OK!! |
With ZED-F9P everything is OK! Registrazione.2024-10-21.190744.mp4 |
small improvement.... Registrazione.dello.schermo.2024-10-22.010347.mp4 |
@nyalldawson Ciao Currently the widget is redrawn at every NMEA sentence received with This is the NMEA sequence for 1 epoch with ZED-F9P: while the NMEA sequence for 1 epoch with UM982 : In ZED-F9P GSA and GSV with contiguous; The UM982 NMEA GSV sentences are much more numerous, as UM982 has a capacity to receive more frequency signals from satellites (just under double compared to ZED-F9P). in the reading period of an NMEA epoch: This explains the flickering! A possible improvement could be to move the widget redrawing ONLY at the completion of an NMEA epoch, i.e. before proceeding with I consider this pull request complete for the moment. |
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
@bettellam sorry to jump in this way, but are there screenshots we could pick here to feed the QGIS docs, please? Or you'd like to provide to QGIS docs? Ours are quite poor as we don't own/play with GPS in the docs team. Thanks in advance. |
Hi @DelazJ , the GPS documentation is actually a bit dated compared to the great update work done by @nyalldawson . |
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist. |
Sorry, I don't understand what's wrong!!! |
parse.c
Update GxGSV - NMEA 4.10
signal_id
sentence.h
Add
signal_id
; //!< NMEA v4.1 - ID of the ranging signalqgsnmeaconnection.cpp
NMEA RMC - Set qualitydescription only for status: A or V in processRmcSentence
if the value in
status
is notA or V
(e.g. D), forqualitydescription
it is set with GGANMEA GSV - Add Signal averaging processGsvSentence
QgsSatelliteInfo signal
is calculated as the average of the signals present in GxGSVWith future updates using
signal_id
you may get a result similar to this:qgsgpsinformationwidget.cpp
Small updates in SkyPlot satellites (added color and different symbol for various constellations)