-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the Trim/Extend Tool to keep the reference line for multiple trim/extend actions #59676
base: master
Are you sure you want to change the base?
Conversation
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
Thanks for this amazing upgrade! I just added a couple of semi related feature requests. Also I think we should upgrade the tool tip help text to identify the modifier and that segment snapping is required to use the tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful! I'd never taken the time to do that, and yet it was just a few lines of code! Many thanks.
Please can you add tests?
@YoannQDQ A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged. Please update the description (not the comments) with helpful description and screenshot to help the work from documentors. Thank you! |
std::unique_ptr<QgsMapMouseEvent> event( new QgsMapMouseEvent( | ||
mCanvas, | ||
QEvent::MouseMove, | ||
QPoint( std::round( pt.x() ), std::round( pt.y() ) ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to cas to an integer. I guess, that you could replace std::round by static_cast.
Description
Pressing Ctrl or Shift while trimming/extending a feature now keeps the reference feature.
Also fix the rubber band display when the layer crs != canvas crs.