Drop qjsonwrapper dependency #59731
Merged
Drop qjsonwrapper dependency #59731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use QMetaObject introspection for this, it's too fragile and subject to warning-less breakage.
|
FYI @rouault |
rouault
reviewed
Dec 3, 2024
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🪟 Windows buildsDownload Windows builds of this PR for testing. |
|
@rouault all addressed! |
rouault
approved these changes
Dec 4, 2024
This is just testing a very low level Qt method which has changed behavior in Qt 6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the oauth2 config to/from json conversion to avoid QMetaObject introspection, as this is fragile and prone to breakage without any compilation warning or errors. This allows us to remove the qjsonwrapper dependency, and drop an unwanted embedded library.