Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pattern option #278

Merged
merged 3 commits into from
Dec 8, 2024
Merged

feat: add pattern option #278

merged 3 commits into from
Dec 8, 2024

Conversation

dvirtz
Copy link
Contributor

@dvirtz dvirtz commented Dec 4, 2024

Closes #110

Changes

add pattern option which is passed as gh-pages src option

  • New code is covered by tests
  • All the changes are mentioned in docs (readme.md)

README.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@dvirtz dvirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebased to fix commit author

@antongolub
Copy link
Member

antongolub commented Dec 7, 2024

@dvirtz,

Yet another rebase is required to fix the test

resolves "Provide minimatch patterns support for `src` option as `gh-pages` does" qiwi#110
Copy link
Contributor Author

@dvirtz dvirtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvirtz,

Yet another rebase is required to fix the test

done

@antongolub antongolub self-requested a review December 8, 2024 14:55
Copy link
Member

@antongolub antongolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@antongolub antongolub merged commit 844769d into qiwi:master Dec 8, 2024
8 checks passed
@dvirtz dvirtz deleted the pattern-option branch December 8, 2024 15:58
@antongolub antongolub mentioned this pull request Dec 8, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide minimatch patterns support for src option as gh-pages does
2 participants